Skip to content

[9.2](backport #45944) chore: fix formatting issues in logp printf-style calls#46908

Closed
mergify[bot] wants to merge 1 commit into9.2from
mergify/bp/9.2/pr-45944
Closed

[9.2](backport #45944) chore: fix formatting issues in logp printf-style calls#46908
mergify[bot] wants to merge 1 commit into9.2from
mergify/bp/9.2/pr-45944

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 2, 2025

Proposed commit message

This PR fixes fatal go vet errors on calls to logp functions. Release v0.22.1 of elastic-agent-libs enabled proper go vet support for printf style calls in logp, and that uncovered many misuses of printing directives.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test

$ go get -u github.com/elastic/elastic-agent-libs@v0.22.1
$ go vet ./...

Related issues

This is an automatic backport of pull request #45944 done by [Mergify](https://mergify.com).

@mauri870 @mergify
chore: fix formatting issues in logp printf-style calls (#45944)
a428349 
* fix go vet errors for logp formatting issues

* chore: fix formatting for logp calls

* revert elastic-agent-libs bump

* Apply suggestions from code review

Co-authored-by: Tiago Queiroz <me@tiago.life>

---------

Co-authored-by: Tiago Queiroz <me@tiago.life>
Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
(cherry picked from commit a5be2a8)

# Conflicts:
#	libbeat/processors/add_host_metadata/add_host_metadata.go
@mergify mergify bot requested a review from a team as a code owner October 2, 2025 13:33
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Oct 2, 2025
@mergify mergify bot requested review from orestisfl and rdner and removed request for a team October 2, 2025 13:33
@mergify
Copy link
Contributor Author

mergify bot commented Oct 2, 2025

Cherry-pick of a5be2a8 has failed:

On branch mergify/bp/9.2/pr-45944
Your branch is up to date with 'origin/9.2'.

You are currently cherry-picking commit a5be2a856.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   libbeat/processors/add_host_metadata/add_host_metadata.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 2, 2025
@mergify mergify bot mentioned this pull request Oct 2, 2025
Merged
6 tasks
@github-actions github-actions bot added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 2, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 2, 2025

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mauri870
Copy link
Member

mauri870 commented Oct 2, 2025

Closing since mergify opened this by mistake when changing labels.

@mauri870 mauri870 closed this Oct 2, 2025
@mergify mergify bot deleted the mergify/bp/9.2/pr-45944 branch October 2, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

@orestisfl orestisfl Awaiting requested review from orestisfl orestisfl is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@mauri870 mauri870

Labels

backport conflicts There is a conflict in the backported pull request Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elasticmachine @mauri870